Fix #4157: Broken error message when trying to eta-expand #4159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-4157
branch
3 times, most recently
from
7c92c83 to
e0684b0
Compare
allanrenucci
approved these changes
Mar 23, 2018
| @@ -72,3 +72,11 @@ scala> val a: iDontExist = 1 | |||
| 1 | val a: iDontExist = 1 | |||
| | ^^^^^^^^^^ | |||
| | not found: type iDontExist | |||
| scala> def foo1(x: => Int) = x _ | |||
There was a problem hiding this comment.
I would make it an error message test instead. They are less fragile
There was a problem hiding this comment.
But I really want to know what the exact output is here :). Can you help me figure out why the test doesn't pass?
Avoid leaking error types in the printed error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid leaking error types in the printed error messages